Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run more tests, formatted a bit differently please review #51

Merged
merged 7 commits into from
Oct 25, 2019

Conversation

dgmouris
Copy link
Contributor

@dgmouris dgmouris commented Oct 7, 2019

Refers to issue:
#28

Copy link
Owner

@ethanchewy ethanchewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall - we should document what each test function does for clarity. See the first comment for more info!

Thanks!



class TestIndexPage(unittest.TestCase):
def setUp(self):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write comments above each test using the reStructure format (for more info, check out the "reStructured Text Example" in https://realpython.com/documenting-python-code/#docstring-formats)

class TestIndexPage(unittest.TestCase):
def setUp(self):
self.app = app.test_client()

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments above this test

index_page = self.app.get('/')
self.assertEqual(index_page.status, '200 OK')
self.assertTrue(b'Python Linter Online' in index_page.data)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments above this test

self.assertTrue('count' in flask.session)
self.assertTrue('time_now' in flask.session)


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments above this test

@ethanchewy ethanchewy merged commit 7de2148 into ethanchewy:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants