-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run more tests, formatted a bit differently please review #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job overall - we should document what each test function does for clarity. See the first comment for more info!
Thanks!
tests/test_app.py
Outdated
|
||
|
||
class TestIndexPage(unittest.TestCase): | ||
def setUp(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write comments above each test using the reStructure format (for more info, check out the "reStructured Text Example" in https://realpython.com/documenting-python-code/#docstring-formats)
tests/test_app.py
Outdated
class TestIndexPage(unittest.TestCase): | ||
def setUp(self): | ||
self.app = app.test_client() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments above this test
index_page = self.app.get('/') | ||
self.assertEqual(index_page.status, '200 OK') | ||
self.assertTrue(b'Python Linter Online' in index_page.data) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments above this test
self.assertTrue('count' in flask.session) | ||
self.assertTrue('time_now' in flask.session) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments above this test
43686a9
to
1aed201
Compare
Refers to issue:
#28